<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Aptos;
panose-1:2 11 0 4 2 2 2 2 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:12.0pt;
font-family:"Aptos",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Aptos",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
mso-ligatures:none;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Class-File API JCK work revealed some of the inappropriately exposed methods in the API.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Below is proposal to remove two methods from
</span><span style="font-size:11.0pt">j.l.classfile.ClassReader.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Please let me know any objections or review the PR and related CSR:
<a href="https://bugs.openjdk.org/browse/JDK-8332598">https://bugs.openjdk.org/browse/JDK-8332598</a><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Thank you,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Adam<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p></o:p></span></p>
<div id="mail-editor-reference-message-container">
<div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:11.0pt">j.l.classfile.ClassReader instance is exposed in the Class-File API through j.l.classfile.AttributeMapper::readAttribute method only.<br>
ClassReader only purpose is to serve as a tool for reading content of a custom attribute in a user-provided AttribtueMapper.<br>
It contains useful set of low-level class reading methods for user to implement a custom attribute content parser.<br>
<br>
However methods <b>ClassReader::thisClassPos</b> and <b>ClassReader::skipAttributeHolder</b> are not necessary for a custom attribute content parsing and so redundant in the API.<br>
Class-File API implementation internally use these methods, however they should not be exposed in the API.<br>
<br>
This patch removes the methods from the API.<br>
<br>
Please review.<br>
<br>
Thanks,<br>
Adam<br>
<br>
-------------<br>
<br>
Commit messages:<br>
- 8332597: Remove redundant methods from j.l.classfile.ClassReader API<br>
<br>
Changes: <a href="https://git.openjdk.org/jdk/pull/19323/files">https://git.openjdk.org/jdk/pull/19323/files</a><br>
Webrev: <a href="https://webrevs.openjdk.org/?repo=jdk&pr=19323&range=00">https://webrevs.openjdk.org/?repo=jdk&pr=19323&range=00</a><br>
Issue: <a href="https://bugs.openjdk.org/browse/JDK-8332597">https://bugs.openjdk.org/browse/JDK-8332597</a><br>
Stats: 26 lines in 5 files changed: 0 ins; 21 del; 5 mod<br>
Patch: <a href="https://git.openjdk.org/jdk/pull/19323.diff">https://git.openjdk.org/jdk/pull/19323.diff</a><br>
Fetch: git fetch <a href="https://git.openjdk.org/jdk.git">https://git.openjdk.org/jdk.git</a> pull/19323/head:pull/19323<br>
<br>
PR: <a href="https://git.openjdk.org/jdk/pull/19323">https://git.openjdk.org/jdk/pull/19323</a><o:p></o:p></span></p>
</div>
</div>
</div>
</div>
</body>
</html>