<div dir="ltr">I see, I do not use the Object-version of the method. The method requires loaded enums anyways what ASM does not provide, and it leaves annotations out, so it could not be used successfully anyways. I think it can be safely removed.<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Am Mi., 14. Aug. 2024 um 23:09 Uhr schrieb Chen Liang <<a href="mailto:chen.l.liang@oracle.com">chen.l.liang@oracle.com</a>>:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="msg-8449773348376043732">
<div dir="ltr">
<div style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
For 3 I am talking about the of(Object) instead of the ofXyz ones, indeed. We seek to remove AnnotationValue.of(Object).</div>
<div style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
Also thanks for the suggestion of this method on CodeBuilder. I personally lean more on dropping automatic computation once this method is called, but feel free to start another thread for more input.</div>
<div style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
Chen</div>
<div style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<br>
</div>
<div id="m_-8449773348376043732appendonsend"></div>
<hr style="display:inline-block;width:98%">
<div id="m_-8449773348376043732divRplyFwdMsg" dir="ltr"><span style="font-family:Calibri,sans-serif;font-size:11pt;color:rgb(0,0,0)"><b>From:</b> Rafael Winterhalter <<a href="mailto:rafael.wth@gmail.com" target="_blank">rafael.wth@gmail.com</a>><br>
<b>Sent:</b> Wednesday, August 14, 2024 3:55 PM<br>
<b>To:</b> Chen Liang <<a href="mailto:chen.l.liang@oracle.com" target="_blank">chen.l.liang@oracle.com</a>><br>
<b>Cc:</b> classfile-api-dev <<a href="mailto:classfile-api-dev@openjdk.org" target="_blank">classfile-api-dev@openjdk.org</a>><br>
<b>Subject:</b> Re: [External] : Re: ASM to OpenJDK ClassReader/ClassWriter bridge: experiences and questions</span>
<div> </div>
</div>
<div style="direction:ltr">As for (3): Do you mean the AnnotationValue.of(Object) method, or the entire hierarchy of AnnotationValue.ofYYY(...) methods? I am only using the latter methods, and I would not know of an alternative tree model. Can you give me
a pointer?</div>
<div style="direction:ltr">As for (4): I would implement this similar to stack map frames. Compute them by default but offer an option to keep them at zero by default:</div>
<div style="direction:ltr"><br>
</div>
<div style="direction:ltr">ClassFile.MethodSizeOptions.COMPUTE<br>
ClassFile.MethodSizeOptions.ZERO</div>
<div style="direction:ltr"><br>
</div>
<div style="direction:ltr">Then there could be a method on CodeBuilder such as "maxs(short, short)" where the relevant values are simply written to the relevant class file location.</div>
<div style="direction:ltr"><br>
</div>
<div style="direction:ltr">Best regards, Rafael</div>
<div><br>
</div>
</div>
</div></blockquote></div>