<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<html><head><meta name="Generator" content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Aptos;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style></head><body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word"><div class="WordSection1"><p class="MsoNormal">Rather than change List<CodeElement> to List<Object> to allow labels to be included, I made a HashMap to associate a Label with the appropriate CodeElement. When doing the cob.with(coe) I check the map and do a cob.labelBinding() as well, if needed. </p><p class="MsoNormal"> </p><p class="MsoNormal">Works nicely and made it fairly easy to solve the ExceptionCatch problem.</p><p class="MsoNormal"> </p><p class="MsoNormal">Thanks to all for your help.</p><p class="MsoNormal"> </p><p class="MsoNormal">Mark</p><p class="MsoNormal"> </p><div><div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0in 0in 0in"><p class="MsoNormal"><b>From:</b> Chen Liang <<a href="mailto:chen.l.liang@oracle.com">chen.l.liang@oracle.com</a>> <br><b>Sent:</b> Wednesday, January 29, 2025 10:08 AM<br><b>To:</b> Mark Roberts <<a href="mailto:markro@cs.washington.edu">markro@cs.washington.edu</a>>; <a href="mailto:classfile-api-dev@openjdk.org">classfile-api-dev@openjdk.org</a><br><b>Subject:</b> Re: [External] : labels</p></div></div><p class="MsoNormal"> </p><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:Aptos;color:black">Hi Mark,</span></p></div><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:Aptos;color:black">An approach can be to use a List<Object>. When you process each item, you pattern match like:</span></p></div><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:Aptos;color:black"> </span></p></div><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:Aptos;color:black">switch(item) {</span></p></div><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:Aptos;color:black">  case LabelTarget lt -> {} // drop</span></p></div><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:Aptos;color:black">  case CodeElement coe -> cob.with(coe);</span></p></div><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:Aptos;color:black">  case Label l -> cob.labelBinding(l);</span></p></div><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:Aptos;color:black">}</span></p></div><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:Aptos;color:black"> </span></p></div><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:Aptos;color:black">I think that can solve your issue.</span></p></div><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:Aptos;color:black"> </span></p></div><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:Aptos;color:black">And I see the transform problem with stack maps is caused by your inability to handle labels. This should be able to avoid those issues in the future.</span></p></div><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:Aptos;color:black"> </span></p></div><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:Aptos;color:black">Regards,</span></p></div><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:Aptos;color:black">Chen Liang</span></p></div></div></body></html>