RFR: 8266435: WBMPImageReader.read() should not truncate the input stream

Sergey Bylokhov serb at openjdk.java.net
Thu Dec 2 00:13:27 UTC 2021


On Wed, 1 Dec 2021 06:12:29 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

>> test/jdk/javax/imageio/plugins/wbmp/WBMPStreamTruncateTest.java line 61:
>> 
>>> 59:         File imageFile = File.
>>> 60:                 createTempFile("test", ".wbmp", new File(filePath));
>>> 61:         imageFile.deleteOnExit();
>> 
>> In one another review I saw the deleteOnExit() usage, I remember that in case of full testrun via makefile, such files were not deleted, can you please confirm that it is work fine? probably that it was fixed already. Note that the full test run uses custom tmp folder inside the result dir.
>
> @mrserb I ran the test using "make test" and i dont see any .wbmp file after test run in results directory.
> Also i verified that it doesn't leave any image in test directory of CI machines.

Ok, thank you for confirmation.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6518



More information about the client-libs-dev mailing list