RFR: 8277299: STACK_OVERFLOW in Java_sun_awt_shell_Win32ShellFolder2_getIconBits [v3]

Alexey Ivanov aivanov at openjdk.java.net
Sat Dec 4 19:36:18 UTC 2021


On Fri, 3 Dec 2021 20:14:43 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp line 1102:
>> 
>>> 1100:                 }
>>> 1101:                 // Release DC
>>> 1102:                 ReleaseDC(NULL, dc);
>> 
>> The DC has to be released even if `colorBits` allocation failed, so this needs to be after `if (colorBits != NULL)`.
>
> Fixed.

Probably, you hasn't pushed the change for releasing the DC.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6473



More information about the client-libs-dev mailing list