RFR: 6465404: some problems in CellEditor related API docs

Alexey Ivanov aivanov at openjdk.java.net
Mon Dec 6 16:40:16 UTC 2021


On Tue, 30 Nov 2021 08:49:19 GMT, Tejesh R <duke at openjdk.java.net> wrote:

> JListBox is invalid component. CellTableEditor Interface doesn't support JComboBox and JTree components. Hence its removed from Documentation.

Please also update the copyright year.

Please also expand the wildcard import at line 30:

import javax.swing.*;

to a specific class import. In fact, this interface imports only `JTable` with the wildcard since `CellEditor` is already imported explicitly.

src/java.desktop/share/classes/javax/swing/table/TableCellEditor.java line 35:

> 33:  * This interface defines the method any object that would like to be
> 34:  * an editor of values for the component <code>JTable</code> that
> 35:  * needs to implement.

Suggestion:

 * an editor of values for the {@code JTable} component needs to implement.

_‘that’_ after `JTable` shouldn't be there.

However, I would suggest rephrasing the Javadoc to make it easier to understand: the sentence has two levels of dependent clauses.

-------------

Changes requested by aivanov (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6608



More information about the client-libs-dev mailing list