RFR: 8247973: Javadoc incorrect for IdentityArrayList, IdentityLinkedList

Alexey Ivanov aivanov at openjdk.java.net
Mon Dec 6 16:54:11 UTC 2021


On Sat, 4 Dec 2021 17:42:41 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> The documentation for following methods used object equality mentioning 'equals()'. I have replaced the equals() with == operator where necessary with some formattings.
>> 
>> sun.awt.util.IdentityLinkedList#contains
>> sun.awt.util.IdentityArrayList#contains
>> sun.awt.util.IdentityArrayList#indexOf
>> sun.awt.util.IdentityArrayList#lastIndexOf
>> sun.awt.util.IdentityArrayList#remove(java.lang.Object) 
>> 
>> Kindly review the change.
>
> Was the previous PR #6694 not good enough?  
> The previous PR has comments to the changes thus you should've referenced it when you created the new one.

> @aivanov-jdk The PR #6694 included HttpURLConnection too. I therefore closed that PR ([#6694 (review)](https://github.com/openjdk/jdk/pull/6694#pullrequestreview-823124988)) and initiated new requested with correct files and changes. As I am slightly new to git I did not know how to update the PR, so I filed a new one.

You could've just reverted the changes to `HttpURLConnection` in your branch and pushed. Effectively, it would've removed the change from the PR.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6710



More information about the client-libs-dev mailing list