RFR: 6462028: MaskFormatter API documentation refers to getDisplayValue [v5]

Tejesh R duke at openjdk.java.net
Wed Dec 15 05:36:01 UTC 2021


On Mon, 6 Dec 2021 17:16:20 GMT, Phil Race <prr at openjdk.org> wrote:

>> src/java.desktop/share/classes/javax/swing/text/MaskFormatter.java line 103:
>> 
>>> 101:  *   MaskFormatter formatter = new MaskFormatter("###-####");
>>> 102:  *   formatter.setPlaceholderCharacter('_');
>>> 103:  *   formatter.getDisplayValue(tf, "123");
>> 
>> This code is part of an example, without this line, the following lines of documentation do not make sense. Probably, `getDisplayValue` should be replaced with `valueToString`. You should check that and ensure the sample and the expected output, as discussed in the following sentences, is correct.
>
> I agree. Simply deleting this line solves nothing. The example needs to be reviewed and the text needs to say something correct and useful.

@prrace The PR has been reviewed and approved by @prsadhuk and @aivanov-jdk...... Can I go ahead and integrate it?

-------------

PR: https://git.openjdk.java.net/jdk/pull/6556



More information about the client-libs-dev mailing list