RFR: 6496103: isFileHidingEnabled return false by default [v2]

Phil Race prr at openjdk.java.net
Fri Dec 17 21:46:21 UTC 2021


On Wed, 15 Dec 2021 06:29:43 GMT, Tejesh R <duke at openjdk.java.net> wrote:

>> The default value of this property is derived from native platform. The same is updated in the documentation.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   6496103: isFileHidingEnabled return false by default

src/java.desktop/share/classes/javax/swing/JFileChooser.java line 1416:

> 1414:      * Returns true if hidden files are not shown in the file chooser;
> 1415:      * otherwise, returns false. The default value of this property is derived
> 1416:      * from native Operating System, unless set explicitly by the programmer.

Is this true on all platforms ? The bug report seems concerned only about windows.
Should the wording be
"The default value of this property may be derived from the underlying operating system"

ie "is" -> "may be" (and some other slight wording change).

If we REALLY will always get it from the O/S, including on Linux, macOS and whatever else .. then it is OK otherwise the new wording would be better.

"unless set explicitly by the programmer."

hmm, well if you set it, it isn't the default, so there's no need to say that, is there ?

-------------

PR: https://git.openjdk.java.net/jdk/pull/6780



More information about the client-libs-dev mailing list