RFR: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled [v3]
Toshio Nakamura
tnakamura at openjdk.java.net
Wed Dec 22 01:40:26 UTC 2021
On Thu, 21 Oct 2021 00:57:47 GMT, Toshio Nakamura <tnakamura at openjdk.org> wrote:
>> Hi,
>>
>> Could you review the fix?
>> When non-English characters were printed from JTable on MacOS, CTextPipe.doDrawGlyphs was called by OSXSurfaceData.drawGlyphs. However, CTextPipe seems not support glyph with slot number of composite fonts.
>>
>> The slot data mask of GlyphVector is 0xff000000. In my environment, Japanese font was loaded at slot 4, and glyph data is like [0x40003e5]. Then, unexpected glyph was drawn.
>
> Toshio Nakamura has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>
> - 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled
> - revert previous proposal
> - Merge branch 'master' into 8240756
> - 2nd proposal
> - Revert previous change
> - Merge branch 'master' into 8240756
> merge master
> - 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled
(Adding comment to keep this PR active.)
This fix tries to fill a gap between a native API and Composite font, since the native API can work for a single font with GlyphVector. This fix switches an appropriate font from the font list of Composite font of Java codes.
I appreciate any comments or advices.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3619
More information about the client-libs-dev
mailing list