RFR: 8198626: java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html fails on mac [v2]

Pankaj Bansal pbansal at openjdk.java.net
Mon Nov 8 14:05:34 UTC 2021


On Mon, 8 Nov 2021 04:24:53 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Pankaj Bansal has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Review comments
>>  - Review Comments
>
> test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.java line 119:
> 
>> 117:                 public void actionPerformed(ActionEvent e) {
>> 118:                     System.err.println("B pressed");
>> 119:                     d.setVisible(true);
> 
> I think the d.setVisible(true) will be blocked and the next "EventQueue.invokeLater" will be executed after the dialog will be closed, unlike the old code where the invokeLater was executed after dialog became visible.

Yes, looks like that. I have reverted this change and ran the test in CI multiple times. Link in JBS

-------------

PR: https://git.openjdk.java.net/jdk/pull/6273



More information about the client-libs-dev mailing list