RFR: 8276058: Some swing test fails on specific CI macos system [v3]

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Wed Nov 10 05:08:39 UTC 2021


On Tue, 9 Nov 2021 19:25:05 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> 
> 
> 
> If tolerance is not needed and the only issue we have is the visible cursor on the screenshot then why do we try to update the tests, maybe we can try to update the jdk instead?

I guess it was already discussed before as below to have the stability improvement in the tests and you agreed to it also but if the stance is changed, I do not have issue in withdrawing this PR.

> > The test part of the fix has multiple stability improvements, and there's no reason to throw that out. And moving the pixel capture position to a more safe position is fine too. I just think that -10 isn't sa\fe enough.
> 
> Sure, I have no comments about the changes related to stability, but there are suspicious cases like using tolerance.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6140



More information about the client-libs-dev mailing list