RFR: JDK-8276800 Fix table headers in NumericShaper.html [v2]

Ludvig Janiuk duke at openjdk.java.net
Wed Nov 10 11:07:40 UTC 2021


On Tue, 9 Nov 2021 19:35:41 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Ludvig Janiuk has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Achieve correct row headers without header change
>
> src/java.desktop/share/classes/java/awt/font/NumericShaper.java line 117:
> 
>> 115:  *     <th scope="col" id="colheader1">Unicode Range
>> 116:  *     <th scope="col" id="colheader2">{@code NumericShaper} Constants
>> 117:  *     <th scope="col" id="colheader3">Precedence
> 
> Shall we use more descriptive ids?
> Suggestion:
> 
>  *     <th scope="col" id="nsUnicodeRangeHeader">Unicode Range
>  *     <th scope="col" id="nsConstantsHeader">{@code NumericShaper} Constants
>  *     <th scope="col" id="nsPrecedence">Precedence

Not relevant anymore given last change

> src/java.desktop/share/classes/java/awt/font/NumericShaper.java line 132:
> 
>> 130:  *     <td headers="rowheader1 colheader3">{@link NumericShaper.Range#EASTERN_ARABIC}
>> 131:  *   <tr>
>> 132:  *     <th scope="row">Tai Tham
> 
> Does it make sense to use `<th scope="rowgroup">` for consistency?

Not relevant anymore given last change

-------------

PR: https://git.openjdk.java.net/jdk/pull/6291



More information about the client-libs-dev mailing list