RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v4]

Magnus Ihse Bursie ihse at openjdk.java.net
Mon Nov 15 14:38:37 UTC 2021


On Mon, 15 Nov 2021 14:00:59 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

>> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set any deployment target when when we use xcrun to create .air file and this issue looks similar to https://developer.apple.com/forums/thread/105719. Also https://developer.apple.com/forums/thread/105719 states that even if they set app deployment target they need to explicitly set deployment in "xcrun metal".
>> 
>> Made same change to use -mmacosx-version-min=10.12.00 in our make file. Whether we should keep 10.12.00 or 10.13/14 is open to discussion for metal pipeline.
>> 
>> SwingSet2, J2DDemo & JCK/jtreg runs in CI are green. Also Vitaly(Submitter) has confirmed that patch resolves the issue.
>
> Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use MACOSX_VERSION_MIN for aarch64

Looks good to me also. Please let Phil have a say as well before integrating.

Also please update the title of the PR and the JBS issue (they must be the same) to something about that we're changing metal min version, rather than the obscure error that was the result of not having the min version...

-------------

Marked as reviewed by ihse (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6346



More information about the client-libs-dev mailing list