RFR: 8169468: NoResizeEventOnDMChangeTest.java fails because FS Window didn't receive all resizes! [v4]
Alexander Zuev
kizune at openjdk.java.net
Tue Nov 16 19:06:00 UTC 2021
> I was able to reproduce this issue locally 2 times out of 100 runs on multi-monitor
> configuration. Both times due to the screen resolution change is so slow window got
> accidentally moved to the secondary screen by the display driver.
> Can not reproduce this bug with ATI card at all.
> Since there is nothing we can do to stop graphics driver from reassigning
> the window if it decides that promary monitor is not on at the moment the
> only way is to check if this has had happened and if so then we can not trust the test
> since we changing resolution of one display and window not getting resized
> because it is placed on another display and test should be skept.
>
> After that i ran this test locally about a thousand times on all platforms
> and has not seen the failure again.
Alexander Zuev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
- Resolve merge conflicts
- Merge branch 'master' into JDK-8169468
- Resolve merge conflict
- Added speel for 2 seconds after setting new display mode.
Removed unneeded imports.
- Check that setting the new display mode ended up with window
residing on the screen with resolution different than one it was before,
even if it the different display - window and components still have to
receive the resize event. Only skipping the iteration where that did not
happened instead of skipping the entire test.
- 8169468: NoResizeEventOnDMChangeTest.java fails because FS Window didn't receive all resizes!
Made sleep() method always sleep at least the requested amount
Checking if window got accidentally reassigned to another graphics device,
skipping test if so.
Removed test from the problem list.
-------------
Changes: https://git.openjdk.java.net/jdk/pull/6186/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6186&range=03
Stats: 26 lines in 2 files changed: 18 ins; 2 del; 6 mod
Patch: https://git.openjdk.java.net/jdk/pull/6186.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/6186/head:pull/6186
PR: https://git.openjdk.java.net/jdk/pull/6186
More information about the client-libs-dev
mailing list