RFR: 8176501: Method Shape.getBounds2D() incorrectly includes Bezier control points in bounding box [v8]

[Jeremy]

On Tue, 16 Nov 2021 04:46:07 GMT, Jeremy <duke at openjdk.java.net> wrote:

>> This removes code that relied on consulting the Bezier control points to calculate the Rectangle2D bounding box. Instead it's pretty straight-forward to convert the Bezier control points into the x & y parametric equations. At their most complex these equations are cubic polynomials, so calculating their extrema is just a matter of applying the quadratic formula to calculate their extrema. (Or in path segments that are quadratic/linear/constant: we do even less work.)
>> 
>> The bug writeup indicated they wanted Path2D#getBounds2D() to be more accurate/concise. They didn't explicitly say they wanted CubicCurve2D and QuadCurve2D to become more accurate too. But a preexisting unit test failed when Path2D#getBounds2D() was updated and those other classes weren't. At this point I considered either:
>> A. Updating CubicCurve2D and QuadCurve2D to use the new more accurate getBounds2D() or
>> B. Updating the unit test to forgive the discrepancy.
>> 
>> I chose A. Which might technically be seen as scope creep, but it feels like a more holistic/better approach.
>> 
>> Other shapes in java.awt.geom should not require updating, because they already identify concise bounds.
>> 
>> This also includes a new unit test (in Path2D/UnitTest.java) that fails without the changes in this commit.
>
> Jeremy has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - 8176501: Method Shape.getBounds2D() incorrectly includes Bezier control points in bounding box
>    
>    This is broadly addresses the code review feedback: "I see many duplicated lines". This commit does NOT include "the previous unified solution" that is also mentioned... so we'll try this on and see how we feel about it.
>    
>    https://github.com/openjdk/jdk/pull/6227#issuecomment-964020449
>  - 8176501: Method Shape.getBounds2D() incorrectly includes Bezier control points in bounding box
>    
>    Applying Laurent's implementation to address machine error.
>    
>    See https://github.com/openjdk/jdk/pull/6227#discussion_r749672090

OK, I refactored the accumulate methods so they're called twice (once for each dimension). What array allocation are you referring to?

-------------

PR: https://git.openjdk.java.net/jdk/pull/6227