RFR: 8264293: Create implementation for NSAccessibilityMenu protocol peer [v2]

Alexander Zuev kizune at openjdk.java.net
Wed Nov 17 16:57:30 UTC 2021


On Wed, 17 Nov 2021 09:55:19 GMT, Anton Tarasov <ant at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fixed parameters layout for better readeability;
>>  - Fixed indentation of native methods;
>>    Fixed initial capacity of rolesMap dictionary;
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CommonComponentAccessibility.m line 1272:
> 
>> 1270:     [ThreadUtilities performOnMainThread:@selector(postMenuOpened)
>> 1271:         on:(CommonComponentAccessibility *)jlong_to_ptr(element)
>> 1272:         withObject:nil waitUntilDone:NO];
> 
> Please move `waitUntilDone` to the new line for consistency.

Fixed.

> src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/MenuAccessibility.m line 35:
> 
>> 33: - (NSAccessibilityRole _Nonnull)accessibilityRole
>> 34: {
>> 35:         return [[[self parent] javaRole] isEqualToString:@"combobox"]
> 
> Please correct the indentation.

Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6421



More information about the client-libs-dev mailing list