RFR: 8262297: ImageIO.write() method will throw IndexOutOfBoundsException [v3]
Masanori Yano
myano at openjdk.java.net
Fri Nov 19 09:04:29 UTC 2021
On Mon, 15 Nov 2021 08:02:19 GMT, Jayathirth D V <jdv at openjdk.org> wrote:
>> Masanori Yano has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - 8262297: ImageIO.write() method will throw IndexOutOfBoundsException
>> - 8262297: ImageIO.write() method will throw IndexOutOfBoundsException
>
> test/jdk/javax/imageio/plugins/bmp/TruncatedPngTest.java line 27:
>
>> 25: * @test
>> 26: * @bug 8262297
>> 27: * @summary Checks that ImageIO.write(..., ..., File) truncates the file
>
> I think with latest patch this summary should be updated to reflect what test is verifying.
I changed summary to verify bit per pixel checking.
> test/jdk/javax/imageio/plugins/bmp/TruncatedPngTest.java line 41:
>
>> 39:
>> 40: public static void main(String[] args) {
>> 41: String fileName = "0.png";
>
> A 2KB image will not take much space but it would be better if we can create 2bpp PNG image programmatically and use it in the test case.
I changed test to use generated BufferdImage and more bpp.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6151
More information about the client-libs-dev
mailing list