RFR: 8274456 : Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java
Sergey Bylokhov
serb at openjdk.java.net
Tue Oct 5 07:11:10 UTC 2021
On Fri, 1 Oct 2021 18:27:21 GMT, lawrence.andrews <github.com+87324768+lawrence-andrew at openjdk.org> wrote:
> 1) Removed =yesno
> 2) After running the test case, test UI will close immediately. Where the user cannot interact so rewrote the test case.
> a) Toolkit Modal Dialog will be shown after clicking the show button.
> b) Added timeout & tested
> c) Step by step instruction what the user has to perform
>
> @shurymury
A few comments:
- Looks like you invert the assertion in the test:
old: "The test fails if the page dialog blocks the toolkit"
new: "Check if page dialog blocks the 'Toolkit modal dialog'. If yes, then test Pass else test fail."
- Please update the copyright date
-------------
PR: https://git.openjdk.java.net/jdk/pull/5789
More information about the client-libs-dev
mailing list