RFR: 8274304: Update or Problem List tests which may fail with uiScale=2 on macOS
Phil Race
prr at openjdk.java.net
Thu Oct 7 23:02:09 UTC 2021
On Thu, 30 Sep 2021 04:43:19 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
> The fix for 8274296 added uiScale=1 to some of the tests to fix the problem of incorrect pixel color capture by the robot.
> In both cases uiScale=1 or uiScale=2 the same call should be made to the macOS. But if uiScale=1 is set we just read one pixel on the screen, but if uiScale=2 is set we prepare the data in some clumsy way(at the end we should also read just one pixel).
>
> Since uiScale=1 affects the test case execution means that we probably have some bugs in the coordinate/size calculation of the area. Note that none of these tests have dependencies on the precise rendering, so it is quite a common use-case and may affect any external applications.
>
> This is a request to update the https://github.com/openjdk/jdk/pull/5687/files
> and move all tests to the problem list.
We already have several bugs problem listed and I do not want to exclude more tests than necessary that work everywhere including hidpi except on some specific h/w and are NOT related to hidpi
So, in other words, leave it as it is. I thought this through when I made the original change and you've said nothing that comes within a mile of convincing me otherwise.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5766
More information about the client-libs-dev
mailing list