RFR: 8272229: BasicSplitPaneDivider:oneTouchExpandableChanged() returns leftButton and rightButton as null with GTKLookAndFeel [v3]

[Pankaj Bansal]

On Tue, 5 Oct 2021 09:26:00 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Pankaj Bansal has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Changes according to JBS discussion
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSplitPaneDivider.java line 379:
> 
>> 377:     /**
>> 378:      * Messaged when the oneTouchExpandable value of the JSplitPane the
>> 379:      * divider is contained in changes. Will create the
> 
> I guess "value of the current JSplitPane divider" makes more sense. 
> Also, I guess leftButton,rightButton wll be created not only if they are null but also when oneTouchExpandable property is set as per code..It might seem to user from current wording that left/right button will be set if they are null even if oneTouchExpandable is not set.

I have addressed the review comments. @prsadhuk  I have not changed the first line as the property change is of JSplitPane not divider. So "value of the current JSplitPane divider changes" will be wrong. It is "value of JSplitpane the divider is contained in changes". All other comments are addressed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5263