RFR: 8254841: [macos] Enter and Exit events shouldn't be sent whilst resizing [v9]
Alisen Chung
github.com+90066231+alisenchung at openjdk.java.net
Fri Oct 8 15:44:09 UTC 2021
On Fri, 1 Oct 2021 22:28:10 GMT, Alisen Chung <github.com+90066231+alisenchung at openjdk.org> wrote:
>> Added a resizing flag when the window is currently being resized to block mouseEntered and mouseExited events from being posted to that window.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>
> removed synthesizeMouseEnteredExitEvent call
> > I think mouseEvents are already posted by macos when the mouse enters the window thru fullscreen-resizing (green button) or tiling, so I think we don't need to synthesize additional events.
>
> If we do not need to synthesize additional events then why do you see a difference in behavior before/after the fix here: [#5497 (comment)](https://github.com/openjdk/jdk/pull/5497#issuecomment-930588684) ?
The case I tested is supposed to be covered by windowDidEnterFullscreen. Also it passed when I tested it manually, but only the automatic test has different behavior..
> > I suggest we remove the line because it introduces another bug where dragging to move the window will post a mouseEntered event without the mouse ever entering the actual window. It also introduces the bug from the original bug report.
>
> But we should not introduce the new one.
I meant that by removing the line 2 different bugs are fixed
-------------
PR: https://git.openjdk.java.net/jdk/pull/5497
More information about the client-libs-dev
mailing list