RFR: 8272229: BasicSplitPaneDivider:oneTouchExpandableChanged() returns leftButton and rightButton as null with GTKLookAndFeel

Pankaj Bansal pbansal at openjdk.java.net
Fri Oct 8 19:38:08 UTC 2021


On Thu, 26 Aug 2021 22:10:52 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> The function documentation for oneTouchExpandableChanged states that the function does couple of things, but in reality  it only does those things if the Look and Feel supports the supportsOneTouchButtons. In case the Look and Feel does not support supportsOneTouchButtons, this functions just returns in beginning and does not do anything.
>> This change clarifies the above in function documentation.
>
> I think that the current test case is wrong, the oneTouchExpandableChanged() should not be called directly, only when the "oneTouchExpandable" property is changed.
> 
> So to consider this as a bug the test should trigger the call to the oneTouchExpandableChanged() as a result of the " oneTouchExpandable value change" and then validate the state of the buttons.

@mrserb Would you like to have a look at the new version as some small changes have been made since you approved this PR? Or I should just integrate the PR?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5263



More information about the client-libs-dev mailing list