RFR: 8168388: GetMousePositionTest fails with the message "Mouse position should not be null" [v3]
Prasanta Sadhukhan
psadhukhan at openjdk.java.net
Thu Oct 21 06:14:02 UTC 2021
On Thu, 21 Oct 2021 05:57:30 GMT, Alexander Zuev <kizune at openjdk.org> wrote:
>> test/jdk/java/awt/Mouse/GetMousePositionTest/GetMousePositionWithOverlay.java line 52:
>>
>>> 50: doTest();
>>> 51: } catch (Exception e) {
>>> 52: if (e instanceof RuntimeException) {
>>
>> Do we need this catch block? I guess main() throws Exception so we can just have try-finally block, no?
>
> The catch block was already there and i decided not to remove it and moved the rest of the code instead of the try block.
I know it was already there but since you are touching the test, it might be better to better the code to remove unneeded block, as here we are just catching exception and rethrowing, when we already have main() signature having "throws Throwable"
-------------
PR: https://git.openjdk.java.net/jdk/pull/6028
More information about the client-libs-dev
mailing list