RFR: 8017175: [TESTBUG] javax/swing/JPopupMenu/4634626/bug4634626.java sometimes failed on mac [v3]

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Fri Oct 29 09:04:12 UTC 2021


On Thu, 28 Oct 2021 09:47:44 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Moved Swing component modification to the EDT.
>> Increased wait time for popup to show up.
>> Made checking variabled volatile.
>> Generic code cleanup.
>> Removed the test from ProblemList.txt
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Moved components instantiation to the EDT

test/jdk/javax/swing/JPopupMenu/4634626/bug4634626.java line 124:

> 122:                 popButton.setComponentPopupMenu(btnPopup);
> 123:                 popButton.setComponentPopupMenu(null);
> 124:             } catch (Exception ex) {

setComponentPopupMenu spec doesn't throw any Exception so I guess we can remove this try block. Anyway init() signature have "throws" signature

-------------

PR: https://git.openjdk.java.net/jdk/pull/6104



More information about the client-libs-dev mailing list