RFR: JDK-8273387: remove some unreferenced gtk-related functions [v2]

Pankaj Bansal pbansal at openjdk.java.net
Wed Sep 8 11:38:08 UTC 2021


On Wed, 8 Sep 2021 07:00:08 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> src/java.desktop/unix/native/libawt_xawt/awt/gtk2_interface.c line 1853:
>> 
>>> 1851: }
>>> 1852: 
>>> 1853: static void gtk2_paint_diamond(WidgetType widget_type, GtkStateType state_type,
>> 
>> I think the function pointer initialiasation of this function `fp_gtk_paint_diamond` should also be removed along with removing the function definition.
>
> Thanks for the hint , I removed the initialization you mentioned.
> 
> Best regards, Matthias

I think the declaration of function pointer should also be removed. So following should be removed from line no 150
static void (*fp_gtk_paint_diamond)(GtkStyle* style, GdkWindow* window,
        GtkStateType state_type, GtkShadowType shadow_type,
        GdkRectangle* area, GtkWidget* widget, const gchar* detail,
        gint x, gint y, gint width, gint height);

-------------

PR: https://git.openjdk.java.net/jdk/pull/5384



More information about the client-libs-dev mailing list