RFR: 8268084: [macos] Disabled JMenuItem arrow is not disabled [v6]
Prasanta Sadhukhan
psadhukhan at openjdk.java.net
Thu Sep 9 07:41:33 UTC 2021
> It is seen in macos disabled JMenuItem arrow is not disabled even though JMenuItem itself is disabled.
> In native app, same menuitem arrow is disabled for disabled menuitem.
>
> Issue is when AquaMenuPainter#paintMenuItem() is called, it tries to draw a ImageIcon image of the arrow via ImageIcon#paintIcon which tries to generate MultiResolutionCachedImage via getResolutionVariant() by calling AquaUtils#generateFilteredImage.
> It does not take into account if disabled arrow icon image needs to be drawn or not, so it is always enabled.
>
> Proposed fix is to generate a disabled ImageIcon image of the same arrow icon and use it for disabled state.
Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
Address review comment
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5310/files
- new: https://git.openjdk.java.net/jdk/pull/5310/files/3c2f69fa..4f555095
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5310&range=05
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5310&range=04-05
Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod
Patch: https://git.openjdk.java.net/jdk/pull/5310.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/5310/head:pull/5310
PR: https://git.openjdk.java.net/jdk/pull/5310
More information about the client-libs-dev
mailing list