RFR: 8268084: [macos] Disabled JMenuItem arrow is not disabled [v5]

[Prasanta Sadhukhan]

On Wed, 8 Sep 2021 20:55:48 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add menuitem checkicon test
>
> src/java.desktop/macosx/classes/com/apple/laf/AquaImageFactory.java line 235:
> 
>> 233:     static class InvertableImageIcon extends ImageIcon implements InvertableIcon, UIResource {
>> 234:         Icon invertedImage;
>> 235:         Icon disabledIcon;
> 
> could be private

done

> src/java.desktop/macosx/classes/com/apple/laf/AquaImageFactory.java line 244:
> 
>> 242:             if (!c.isEnabled()) {
>> 243:                 if (disabledIcon == null) {
>> 244:                     disabledIcon = new ImageIconUIResource(GrayFilter.
> 
> It is not necessary to use ImageIconUIResource since we never return this image but only draw it.

done

> test/jdk/javax/swing/plaf/aqua/JMenuItemDisableArrowButtonTest.java line 27:
> 
>> 25:  * @requires (os.family == "mac")
>> 26:  * @bug 8268084
>> 27:  * @summary  Verifies disabled JMenuItem arrow is disabled
> 
> arrow and check

done

-------------

PR: https://git.openjdk.java.net/jdk/pull/5310