RFR: 8205137: Remove Applet support from SwingSet2 [v3]

Alexey Ivanov aivanov at openjdk.java.net
Mon Sep 13 20:12:55 UTC 2021


On Fri, 10 Sep 2021 23:34:19 GMT, Alisen Chung <github.com+90066231+alisenchung at openjdk.org> wrote:

>> removed support for running demo from applet for J2Ddemo and SwingSet2
>> same PR as 8205137: Remove Applet support from SwingSet2 #5400 (changed branch name)
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8205137: Reverted accidental code reformat
>   
>   Reviewed-by: alichung

I asked about imports because I usually see `java.*` followed by `javax.*` followed by internal imports in the JDK code. I wanted to confirm my understanding.

If I remember correctly, IDEA has a different order by default: other imports, then `java.*` and `javax.*`. I can see the motivation here: for projects using Java, you care about your own classes more than `java(x)` packages. For JDK, java(x) are the important ones.

In this case, the previous order of the imports was preserved where `javax.*` imports were before `java.*`. In addition to that, SwingSet2 is a demo of Swing components, so having `javax.swing.*` above `java.awt.*` makes sense to me too.

> Here I note that the pre-existing wild card imports were of javax.swing followed by java.awt*
> and the change is preserving that so I don't have a strong opinion on that nor do I think I
> would insist on lexical ordering but I also would be quite fine if the fixer is OK to make that change.

I'm also fine with either order of the imports.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5401



More information about the client-libs-dev mailing list