RFR: 8273684: Unnecessary Stack usage

Chris Plummer cjplummer at openjdk.java.net
Wed Sep 15 16:31:54 UTC 2021


On Wed, 15 Sep 2021 10:53:47 GMT, Andrey Turbanov <github.com+741251+turbanoff at openjdk.org> wrote:

>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java line 988:
>> 
>>> 986:                 // Make sure the types are emitted in an order than can be read back in
>>> 987:                 HashSet<String> emitted = new HashSet<>();
>>> 988:                 ArrayDeque<Type> pending = new ArrayDeque<>();
>> 
>> Have you run the clhsdb vmstructsdump command to make sure the ordering hasn't changed?
>
> Checked.
> Ordering is the same.
> ![изображение](https://user-images.githubusercontent.com/741251/133420954-67404798-b56d-4d6f-98ee-c457622d58f4.png)
> 
> [with_fixes_java_vmstructsdump.txt](https://github.com/openjdk/jdk/files/7169440/with_fixes_java_vmstructsdump.txt)
> [without_fixes_java_vmstructsdump.txt](https://github.com/openjdk/jdk/files/7169441/without_fixes_java_vmstructsdump.txt)

There is something wrong with the version of jhsdb you are running. It appears to be an old version, not the latest. You should not be seeing the following warning. The code that produces it is not even present in the latest jdk.
`Warning: Nashorn engine is planned to be removed from a future JDK release`

-------------

PR: https://git.openjdk.java.net/jdk/pull/5294



More information about the client-libs-dev mailing list