RFR: 8272229: BasicSplitPaneDivider:oneTouchExpandableChanged() returns leftButton and rightButton as null with GTKLookAndFeel [v2]

Patrick Chen chen.j.patrick at gmail.com
Thu Sep 16 09:06:21 UTC 2021


You should review your patch I comment the last line
do not merge

Le jeu. 16 sept. 2021 à 11:01, Pankaj Bansal <pbansal at openjdk.java.net> a
écrit :

> > The function documentation for oneTouchExpandableChanged states that the
> function does couple of things, but in reality  it only does those things
> if the Look and Feel supports the supportsOneTouchButtons. In case the Look
> and Feel does not support supportsOneTouchButtons, this functions just
> returns in beginning and does not do anything.
> > This change clarifies the above in function documentation.
>
> Pankaj Bansal has updated the pull request incrementally with one
> additional commit since the last revision:
>
>   Incorporate the suggestions in JBS discussion
>
> -------------
>
> Changes:
>   - all: https://git.openjdk.java.net/jdk/pull/5263/files
>   - new:
> https://git.openjdk.java.net/jdk/pull/5263/files/3f5cf6d8..f7b79a9d
>
> Webrevs:
>  - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5263&range=01
>  - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5263&range=00-01
>
>   Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod
>   Patch: https://git.openjdk.java.net/jdk/pull/5263.diff
>   Fetch: git fetch https://git.openjdk.java.net/jdk
> pull/5263/head:pull/5263
>
> PR: https://git.openjdk.java.net/jdk/pull/5263
>



More information about the client-libs-dev mailing list