RFR: 8262945: [macos] Regression Manual Test for Key Events Fails

Alexander Zuev kizune at openjdk.java.net
Tue Sep 21 18:33:31 UTC 2021


On Tue, 21 Sep 2021 18:00:13 GMT, Alisen Chung <github.com+90066231+alisenchung at openjdk.org> wrote:

> Added a check for active keyboard language and added support for Russian NSEvent keyCodes to JavaVirtualKeyCode translation. Originally, only English characters were checked for even if other languages were in native letterCharacterSet. Can be easily expanded to include other languages as well.

src/java.desktop/macosx/native/libawt_lwawt/awt/AWTEvent.m line 483:

> 481:             *keyLocation = java_awt_event_KeyEvent_KEY_LOCATION_STANDARD;
> 482:             return;
> 483:         } else if([lang isEqualToString:@"ru"]) {

Does it affect only Russian locale? What about other non-Latin locales? Seems little bit too narrow of a fix.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5617



More information about the client-libs-dev mailing list