RFR: 8274016: Replace 'for' cycles with iterator with enhanced-for in java.desktop

[Sergey Bylokhov]

On Sun, 19 Sep 2021 10:13:49 GMT, Andrey Turbanov <github.com+741251+turbanoff at openjdk.org> wrote:

> There are few places in code where manual `for` loop is used with Iterator to iterate over Collection.
> Instead of manual `for` cycles it's preferred to use enhanced-for cycle instead: it's less verbose, makes code easier to read and it's less error-prone.
> It doesn't have any performance impact: java compiler generates similar code when compiling enhanced-for cycle.
> This is continuation of [JDK-8258006](https://bugs.openjdk.java.net/browse/JDK-8258006)

src/java.desktop/share/classes/com/sun/imageio/plugins/common/SimpleRenderedImage.java line 285:

> 283:         }
> 284: 
> 285:         // Copy the strings from the Vector over to a String array.

Looks like JDK-8271603 missed "Vector" here.

src/java.desktop/share/classes/com/sun/imageio/plugins/common/SimpleRenderedImage.java line 289:

> 287:         int count = 0;
> 288:         for (String name : names) {
> 289:             prefixNames[count++] = name;

Why we cannot use names.toArray here?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5578