RFR: 8262945: [macos] Regression Manual Test for Key Events Fails [v3]

Alisen Chung github.com+90066231+alisenchung at openjdk.java.net
Mon Sep 27 16:19:21 UTC 2021


> Added a check for active keyboard language and added support for Russian NSEvent keyCodes to JavaVirtualKeyCode translation. Originally, only English characters were checked for even if other languages were in native letterCharacterSet. Can be easily expanded to include other languages as well.

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  adding comment explaining offset numbers

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5617/files
  - new: https://git.openjdk.java.net/jdk/pull/5617/files/05f376c6..9bb582a9

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5617&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5617&range=01-02

  Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5617.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5617/head:pull/5617

PR: https://git.openjdk.java.net/jdk/pull/5617



More information about the client-libs-dev mailing list