RFR: 8283794: CCE in XRTextRenderer.drawGlyphList and XRMaskFill.MaskFill [v2]

Sergey Bylokhov serb at openjdk.java.net
Wed Apr 6 05:36:44 UTC 2022


On Fri, 1 Apr 2022 15:43:29 GMT, Alexey Ushakov <avu at openjdk.org> wrote:

>> Throwing InvalidPipeException for incompatible surfaces
>
> Alexey Ushakov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8283794: CCE in XRTextRenderer.drawGlyphList and XRMaskFill.MaskFill
>   
>   Extracted try/catch logic of SurfaceData cast to particular SurfaceData subclass into convenience method SurfaceData.convertTo(). Applied the method to XRTextRenderer.drawGlyphList() and XRMaskFill.MaskFill(). Refactored try/catch blocks handling similar cases.

Looks fine, I suggest checking the fix via mach5. @aghaisas please take a look.

-------------

Marked as reviewed by serb (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8015



More information about the client-libs-dev mailing list