RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage [v12]
Alexey Ivanov
aivanov at openjdk.java.net
Wed Apr 6 10:27:15 UTC 2022
On Wed, 6 Apr 2022 09:52:47 GMT, Tejesh R <duke at openjdk.java.net> wrote:
>> Removed the println() line from the Interrupted catch block. Since waitForID() Interrupt indicates completion of Image Loading, println as Interrupt handling was not required.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>
> Updated based on Reiview comments
test/jdk/javax/swing/ImageIcon/LoadInterruptTest.java line 37:
> 35: * @bug 8236987
> 36: * @summary Verifies ImageIcon constructor produces no output when the
> 37: * thread is interrupted
Suggestion:
* @summary Verifies ImageIcon constructor produces no output when the
* thread is interrupted
I believe this improves the readability of the summary and it's usually formatted like this.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7754
More information about the client-libs-dev
mailing list