RFR: 8284444: Sting typo

Alexey Ivanov aivanov at openjdk.java.net
Wed Apr 6 13:42:41 UTC 2022


On Wed, 6 Apr 2022 12:07:30 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

> This patch adds missing `r` in `string`s

src/java.desktop/share/native/liblcms/cmstypes.c line 3668:

> 3666: // Auxiliary, read an string specified as count + string
> 3667: static
> 3668: cmsBool  ReadCountAndString(struct _cms_typehandler_struct* self, cmsIOHANDLER* io, cmsMLU* mlu, cmsUInt32Number* SizeOfTag, const char* Section)

As @kevinrushforth mentioned, we usually don't modify the source from external libraries. You should report and fix the problem upstream.

src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources.properties line 63:

> 61: message.creating-association-with-null-extension=Creating association with null extension.
> 62: message.wrong-tool-version=Detected [{0}] version {1} but version {2} is required.
> 63: message.version-string-too-many-components=Version string may have up to 3 components - major.minor.build .

I wonder whether the space before the period is required at the end of the sentence. Perhaps, it's to separate a property name from the end of the sentence.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8125



More information about the client-libs-dev mailing list