RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v4]
Tejesh R
duke at openjdk.java.net
Fri Apr 8 10:21:22 UTC 2022
> getText function returned extra endOfLine when appended. The reason was in `EditorEditorKit` class, `write(Writer out, Document doc, int pos, int len)` method, where translation happens from buffer to Out(Writer Object) if endOfLine is other than '\n' ( which is '\r\n' in windows). In order to write each line till End of line, the string till '\n' is written including '\r' and again endOfLine is written which results in extra Carriage Return. To solve this issue, a Condition is added which checks if previous character to '\n' is '\r', if true then whole string except Carriage Return ('\r') is written, else whole string till before '\n' is written.
Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
Updated based on Review Comments
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8122/files
- new: https://git.openjdk.java.net/jdk/pull/8122/files/f1b6e3ea..2369b965
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8122&range=03
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8122&range=02-03
Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
Patch: https://git.openjdk.java.net/jdk/pull/8122.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/8122/head:pull/8122
PR: https://git.openjdk.java.net/jdk/pull/8122
More information about the client-libs-dev
mailing list