RFR: 8280468: Crashes in getConfigColormap, getConfigVisualId, XVisualIDFromVisual on Linux [v5]

Maxim Kartashev duke at openjdk.java.net
Fri Apr 8 19:11:56 UTC 2022


On Fri, 8 Apr 2022 16:20:10 GMT, Phil Race <prr at openjdk.org> wrote:

> why did you get rid of the just in case ?

I honestly couldn't find any way for this code to get executed. I can keep it there, but then I would have to explain why it is needed.

> Actually why is this method being modified at all ?
The changes are really semantically null. All I did was shorten a 30 lines method to 15 and gave a name to a piece of it (but that's in the next comment).

-------------

PR: https://git.openjdk.java.net/jdk/pull/7182



More information about the client-libs-dev mailing list