RFR: 8280468: Crashes in getConfigColormap, getConfigVisualId, XVisualIDFromVisual on Linux [v3]

[Maxim Kartashev]

On Fri, 8 Apr 2022 16:19:30 GMT, Phil Race <prr at openjdk.org> wrote:

> I don't understand why this was extracted out. It isn't called anywhere else and again makes the diff harder to understand.

This AWT lock should be held for a very small portion of the original method. Initially, I left the code guarded by it in place and it looked weird and out of place. I understand that this is a judgement call, though.

As for the diffs, they are not very significant (essentially, 4 lines of code were re-grouped and moved around) and we only have to look at them here for a few days. The (refactored) code itself will be looked at by (presumably) a greater number of people over a far greater period of time. Less of a judgement call.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7182