RFR: JDK-8282778: Create a regression test for JDK-4699544 [v3]
Sergey Bylokhov
serb at openjdk.java.net
Tue Apr 12 01:29:53 UTC 2022
On Wed, 30 Mar 2022 10:54:32 GMT, Srinivas Mandalika <smandalika at openjdk.org> wrote:
>> Create a regression test for JDK-4699544
>>
>> The subclass of javax.swing.JRootPane (AccessibleJRootPane) that implements the accessibility interface javax.accessibility.AccessibleComponent is derived from java.awt.AccessibleAWTComponent, which returns null for getAccessibleAt() because a component does not necessarily have childs.
>>
>> The root pane always has a content pane child, so getAccessibleAt() should be overwritten by AccessibleJRootPane appropriately.
>> The test added verifies the same.
>> This review is for migrating tests from a closed test suite to open.
>
> Srinivas Mandalika has updated the pull request incrementally with one additional commit since the last revision:
>
> Review Comments Fixed: Frame on EDT, Line length <= 80 characters
test/jdk/javax/accessibility/4699544/JRootPaneAccessiblAtTest.java line 39:
> 37: public class JRootPaneAccessiblAtTest extends JFrame {
> 38: JRootPane rootPane;
> 39: AccessibleComponent accessibleComponent;
Look like these fields became redundant.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7739
More information about the client-libs-dev
mailing list