RFR: 8284077: Create an automated test for JDK-4170173 [v2]

Srinivas Mandalika smandalika at openjdk.java.net
Tue Apr 12 06:14:40 UTC 2022


On Sat, 9 Apr 2022 05:32:02 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Srinivas Mandalika has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review Comments Fixed: Simplied test
>
> test/jdk/javax/accessibility/4170173/AccessibleJTextAfterIndexTest.java line 114:
> 
>> 112:             jTextComponent.getAccessibleContext().getAccessibleText()
>> 113:             .getAfterIndex(character, characterPosition));
>> 114: 
> 
> It feels that the code above is too smart=) Can we simplify/reformat it a little bit. I do not think that you need to jump from the main thread to the EDT and back for each testcase, just wrap the "doTest" by the invokeAndWait

This is a really good suggestion, thank you. I have simplified the test.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8138



More information about the client-libs-dev mailing list