RFR: 7132796: [macosx] closed/javax/swing/JComboBox/4517214/bug4517214.java fails on MacOS
Prasanta Sadhukhan
psadhukhan at openjdk.java.net
Thu Apr 14 09:38:11 UTC 2022
On Thu, 14 Apr 2022 09:17:17 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> JDK-4517214 was fixed for Metal L&F where JComboBox having TitledBorder used to have double height compared to normal JComboBox.
>> The issue is still observed for macos for Aqua L&F where still double height is seen.
>> Fix is to prevent adding border insets height to combobox size as was done for [MetalComboxUI.getMinimumSize[](url)](https://github.com/openjdk/jdk/blame/master/src/java.desktop/share/classes/javax/swing/plaf/metal/MetalComboBoxUI.java#L384)
>> The closed test is automated and moved to open. CI testing on all platform is ok.
>
> test/jdk/javax/swing/JComboBox/TestComboBoxHeight.java line 48:
>
>> 46:
>> 47: public static void main(String[] args) throws Exception {
>> 48: try {
>
> Can we check all L&Fs?
Not now..we already have open JBS for window L&F JDK-8233469 and it also fails in Nimbus which will be looked into separately..
I will like this PR to be for for default L&F only otherwise it will cause failure in CI systems..
-------------
PR: https://git.openjdk.java.net/jdk/pull/8237
More information about the client-libs-dev
mailing list