RFR: 7132796: [macosx] closed/javax/swing/JComboBox/4517214/bug4517214.java fails on MacOS

Jayathirth D V jdv at openjdk.java.net
Mon Apr 18 13:20:42 UTC 2022


On Mon, 18 Apr 2022 04:14:29 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> JDK-4517214 was fixed for Metal L&F where JComboBox having TitledBorder used to have double height compared to normal JComboBox.
>> The issue is still observed for macos for Aqua L&F where still double height is seen.
>> Fix is to prevent adding border insets height to combobox size as was done for [MetalComboxUI.getMinimumSize[](url)](https://github.com/openjdk/jdk/blame/master/src/java.desktop/share/classes/javax/swing/plaf/metal/MetalComboBoxUI.java#L384)
>> The closed test is automated and moved to open. CI testing on all platform is ok.
>
> Any more comments on this @mrserb ?

@prsadhuk I am not seeing an internal PR to remove this test case from closed repo. I thought we usually raise closed PR first about movement and then open PR. Have things changed recently.

Also having "closed" in open PR title is confusing.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8237



More information about the client-libs-dev mailing list