Integrated: 8284521: Write an automated regression test for RFE 4371575

Manukumar V S mvs at openjdk.java.net
Tue Apr 19 05:54:29 UTC 2022


On Thu, 7 Apr 2022 11:08:38 GMT, Manukumar V S <mvs at openjdk.org> wrote:

> Write an automated regression test for [JDK-4371575](https://bugs.openjdk.java.net/browse/JDK-4371575)
> 
> Issue:
> As part of the Merlin focus project, JComponent.setRequestFocusEnabled was
> deprecated and its implementation was changed to map exactly to the new
> method Component.setFocusable. Scott believes that the old behavior may be
> preferable. He would like to be able to specify that a Component is focusable,
> and should receive focus during keyboard traversal, but that it should not
> automatically take focus when the user clicks on it with the mouse.
> 
> We are concerned that the accessibility team would be against this behavior,
> and this also seems like more of a PLAF issue. Nevertheless, we should look
> into it before beta ships.
> 
> Fix:
> After some discussion we decided that the best balance of the old and new would be to make this an advisory property. This property will not be synonymous with focusable. Instead our mouse listeners will check this property before requesting focus. This provides as closely as possible the old behavior, while allowing people to use the new focusable property if they don't want a component focusable at all.
> 
> Testing:
> Tested in mach5, 10 times with all the 3 available platform like macosx, windows and linux and got all Pass.

This pull request has now been integrated.

Changeset: 447c2d13
Author:    Manukumar V S <mvs at openjdk.org>
Committer: Abdul Kolarkunnu <akolarkunnu at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/447c2d13d055fbe640ec4714a961543a03a4f2ad
Stats:     138 lines in 1 file changed: 138 ins; 0 del; 0 mod

8284521: Write an automated regression test for RFE 4371575

Reviewed-by: prr, serb

-------------

PR: https://git.openjdk.java.net/jdk/pull/8143



More information about the client-libs-dev mailing list