RFR: 8283803: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test [v9]

[Alexey Ivanov]

On Tue, 19 Apr 2022 17:03:16 GMT, lawrence.andrews <duke at openjdk.java.net> wrote:

>> Fixed the following issue.
>> 1) Removed yes/no since test was failing due to "Parser error due to yesno in @run main/manual=yesno"
>> 2) After removing yes/no test run( just shows the UI and gets dispose immediately). User cannot interact with the test UI and mark the test pass or failed. 
>> So added Pass and Fail button to mark the test result.
>> 3) Added timeout if in case user does not interact with the test UI.
>> 
>> @shurymury 
>> @aivanov-jdk
>
> lawrence.andrews has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Merge branch 'JDK-8283803' of https://github.com/lawrence-andrew/jdk into JDK-8283803
>  - Removed checking pj for null

Marked as reviewed by aivanov (Reviewer).

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 123:

> 121:         instructionsText.setLineWrap(true);
> 122: 
> 123:         long tTimeout = TimeUnit.MINUTES.toMillis(testTimeOut);

Here you could probably reused `testTimeout`:

testTimeOut = TimeUnit.MINUTES.toMillis(testTimeOut);

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 197:

> 195:      *                                   interrupted
> 196:      * @throws InvocationTargetException if an exception is thrown while
> 197:      *                                   disposing frames on EDT

Suggestion:

     *                                   disposing of frames on EDT

“Dispose” requires the preposition.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8004