RFR: 8284993: Replace System.exit call in swing tests with RuntimeException [v2]

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Wed Apr 20 09:23:15 UTC 2022


On Tue, 19 Apr 2022 18:32:39 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - test fix
>>  - test fix
>
> test/jdk/javax/swing/JComboBox/8019180/Test8019180.java line 66:
> 
>> 64:             }
>> 65:             SwingUtilities.getWindowAncestor(this.test).dispose();
>> 66:             LATCH.countDown();
> 
> Looks like that before the fix all tests had graceful shutdown in standalone mode.
> 
> Now there are hanging open windows when they fails.
> e.g. those two lines could be wrapped in `finally` block for graceful test finish.

I am not able to reproduce this observation. Anyway, I have added dispose in finally block

-------------

PR: https://git.openjdk.java.net/jdk/pull/8293



More information about the client-libs-dev mailing list