RFR: 8196367: java/awt/List/SingleModeDeselect/SingleModeDeselect.java times out [v2]

Alexander Zuev kizune at openjdk.java.net
Fri Apr 22 22:27:26 UTC 2022


On Fri, 22 Apr 2022 17:54:49 GMT, DamonGuy <duke at openjdk.java.net> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use one tyr/catch instead of two
>>   Generic code cleanup
>
> test/jdk/java/awt/List/SingleModeDeselect/SingleModeDeselect.java line 66:
> 
>> 64:                 throw new RuntimeException("Test failed: List.getSelectedIndex() returns "+list.getSelectedIndex());
>> 65:             }
>> 66:         } finally {
> 
> Can these try blocks be combined into one block? Also from my previous PR's, I believe it's standard to have spaces around the "+" before `list.getSelectedIndex()`.

Yeah, it is part of the old code but since i'm moving these lines around i might as well fix that.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8351



More information about the client-libs-dev mailing list