RFR: 8284767: Create an automated test for JDK-4422535 [v2]

Srinivas Mandalika smandalika at openjdk.java.net
Tue Apr 26 09:28:28 UTC 2022


> Create an automated test for [JDK-4422535](https://bugs.openjdk.java.net/browse/JDK-4422535)
> AccessibleValue implementation only accept Integers
> The AccessibleValue implementations of the following components:
> 
> java.awt.Scrollbar
> javax.swing.AbstractButton
> javax.swing.JInternalFrame
> javax.swing.JSplitPane
> javax.swing.JScrollBar
> javax.swing.JProgressBar
> javax.swing.JSlider
> 
> require the argument to setCurrentAccessibleValue(Number) to be an Integer, else they completely ignore it - it returns a false indicating that the value has not been set by the return value, but they cannot know the reason for that).
> 
> The test verifies that for each of the above components, the AccessibleValue is set when it is set to a Number (Float, Double, long etc) and not just for an Integer.
> 
> his review is for migrating tests from a closed test suite to open.
> 
> Testing:
> The test ran successfully on Mach5 with multiple runs (30) on windows-x64, linux-x64 and macos-x64.

Srinivas Mandalika has updated the pull request incrementally with one additional commit since the last revision:

  Review Comments Fixed: Simplified test code with a loop over the JComponents being tested.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8220/files
  - new: https://git.openjdk.java.net/jdk/pull/8220/files/21061b62..8536a648

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8220&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8220&range=00-01

  Stats: 267 lines in 1 file changed: 4 ins; 248 del; 15 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8220.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8220/head:pull/8220

PR: https://git.openjdk.java.net/jdk/pull/8220



More information about the client-libs-dev mailing list