RFR: 7124282: [macosx] Can't see table cell highlighter when the highlight border is the same color as the cell. [v11]

Harshitha Onkar duke at openjdk.java.net
Tue Apr 26 17:05:12 UTC 2022


On Tue, 26 Apr 2022 05:57:32 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added new color to CSystemColors.m - CELL_HIGHLIGHT_COLOR
>
> src/java.desktop/macosx/classes/com/apple/laf/AquaLookAndFeel.java line 392:
> 
>> 390: 
>> 391:         // for table cell highlighter
>> 392:         final Color cellFocusRing = AquaImageFactory.getCellHighlightColorUIResource();
> 
> overall looks ok. I believe you have tested well in BigSur and Monterey also..
> Minor nit, this cellFocusRing should be "cellFocusRingColor" like other color variables.

@prsadhuk I have tested it on BigSur and Monterey, the new changes are working well. I will change the variable name as suggested and update the PR.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7768



More information about the client-libs-dev mailing list